Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix act errors in FixedOrMetricControl test #22334

Merged
merged 1 commit into from
Dec 6, 2022
Merged

test: Fix act errors in FixedOrMetricControl test #22334

merged 1 commit into from
Dec 6, 2022

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This PR fixes 8 act errors in superset-frontend/src/explore/components/controls/FixedOrMetricControl/FixedOrMetricControl.test.tsx

TESTING INSTRUCTIONS

  • cd into superset-frontend
  • run npm run test superset-frontend/src/explore/components/controls/FixedOrMetricControl/FixedOrMetricControl.test.tsx
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 6, 2022 •
edited
Loading

Codecov Report

Merging #22334 (c9e85d4) into master (2f23a9c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22334   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1847     1847           
  Lines       70561    70561           
  Branches     7737     7737           
=======================================
  Hits        47174    47174           
  Misses      21380    21380           
  Partials     2007     2007
Flag Coverage Δ
hive 52.53% <ø> (ø)
javascript 53.80% <ø> (ø)
mysql 77.95% <ø> (ø)
postgres 78.02% <ø> (ø)
presto 52.42% <ø> (ø)
python 81.23% <ø> (ø)
sqlite 76.48% <ø> (ø)
unit 50.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lyndsiWilliams lyndsiWilliams merged commit 4cf40fb into master Dec 6, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/fix-act-errors-FixedOrMetricControl branch December 6, 2022 13:29
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyndsiWilliams @michael-s-molina @mistercrunch